Can we chill out on the patches?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Can we chill out on the patches?

Oliver Charles
Seriously, I come back to my inbox after 2 hours and find it bursting
with 60 patches. That's not going to help anyone and is just going to
lead to bad reviews. Give us a few patches at a time and we can
systematically work through them. This is better than a monolithic
patch, but this is still pretty crazy.

--
    Oliver Charles / aCiD2

_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Brian Schweitzer
My apologies for all the emails - I seriously don't think we need to have code review sending an email to the list, ever (let alone that it's faking them as if they were sent directly from my email address...).

I honestly have no idea how we want to handle this patch, however.  Whether all one patch, or as multiple small patches, everyone's complaining about it.  However, I've said repeatedly, this is just the same as, for example, the forms system change, when over a hundred files needed to be modified, or things broke - not just the template not looking right, but templates themselves moving, and things happening in very different ways (template-side), such that tt would error out unless the template were updated.

That said, all the "piecemeal" newUI patches have now been either sent (when cr didn't like them) or attached to codereview.  Most of them, as can now hopefully be more easily seen, are very minor, and should be able to get cleared from the patch queue rather quickly. :)

Again, though, my apologies for cr sending all the spam in my name...  I'm not very happy with that either.  :(

Brian

On Thu, Apr 30, 2009 at 6:02 PM, Oliver Charles <[hidden email]> wrote:
Seriously, I come back to my inbox after 2 hours and find it bursting
with 60 patches. That's not going to help anyone and is just going to
lead to bad reviews. Give us a few patches at a time and we can
systematically work through them. This is better than a monolithic
patch, but this is still pretty crazy.

--
   Oliver Charles / aCiD2

_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Oliver Charles
On Thu, Apr 30, 2009 at 11:13 PM, Brian Schweitzer
<[hidden email]> wrote:

> My apologies for all the emails - I seriously don't think we need to have
> code review sending an email to the list, ever (let alone that it's faking
> them as if they were sent directly from my email address...).
>
> I honestly have no idea how we want to handle this patch, however.  Whether
> all one patch, or as multiple small patches, everyone's complaining about
> it.  However, I've said repeatedly, this is just the same as, for example,
> the forms system change, when over a hundred files needed to be modified, or
> things broke - not just the template not looking right, but templates
> themselves moving, and things happening in very different ways
> (template-side), such that tt would error out unless the template were
> updated.
>
> That said, all the "piecemeal" newUI patches have now been either sent (when
> cr didn't like them) or attached to codereview.  Most of them, as can now
> hopefully be more easily seen, are very minor, and should be able to get
> cleared from the patch queue rather quickly. :)
>
> Again, though, my apologies for cr sending all the spam in my name...  I'm
> not very happy with that either.  :(

It's not really the emails - it's the volume of patches. Integrators
are gonna have to go through them, check them and then merge them in.
Seeing a massive huge list just adds stress and it's not going to get
the job done any faster.

--
    Oliver Charles / aCiD2

_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Robert Kaye
Administrator
In reply to this post by Oliver Charles

On Apr 30, 2009, at 3:02 PM, Oliver Charles wrote:

> Seriously, I come back to my inbox after 2 hours and find it bursting
> with 60 patches. That's not going to help anyone and is just going to
> lead to bad reviews. Give us a few patches at a time and we can
> systematically work through them. This is better than a monolithic
> patch, but this is still pretty crazy.

+1000

--

--ruaok      A village in Texas has its idiot back!

Robert Kaye     --     [hidden email]     --    http://mayhem-chaos.net


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Nikolai Prokoschenko
Administrator
In reply to this post by Oliver Charles
Oliver Charles <[hidden email]> writes:

> Seriously, I come back to my inbox after 2 hours and find it bursting
> with 60 patches. That's not going to help anyone and is just going to
> lead to bad reviews. Give us a few patches at a time and we can
> systematically work through them. This is better than a monolithic
> patch, but this is still pretty crazy.

I have to say I understand your anger, but I personally am perfectly
fine with that. I prefer that to a lot of mails in the mailing list.

We now have a lot of patches in the queue which can be
worked on piece by piece -- neither should you review all that stuff at
once nor should you review that alone. Many patches at once are only
problematic for the submitter, since he's the one responsible for the
patch to apply cleanly (something RB checks rudimentally). It's also his
problem if some of his later patches require earlier patches to get
submitted. And I also prefer having too many patches to review than too
few, since that actually means we *have* so many patches at all. None of
those get lost, as opposed to patches in the mailing list.

As for the second problem, mail filtering, I do understand the problem
with e-mail address forging, but it helps to follow the discussion
cleanly. I however don't understand the problem with too many mails:
it's not difficult at all to sort those mails out, for example by
setting your e-mail address to [hidden email]. If you don't
like them, remove you address at all. It also helps not having all users
in the default reviewer group but rather separating them into topic
groups, e.g. NGS, JS, Templates.

But maybe that's just me -- I prefer having too much information to too
little. In any case we shouldn't be encouraging developers to submit
less patches just because our infrastructure can't handle that yet.

Nikolai.


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Paul C. Bryan-2
Is it worth spinning off patches to a different mailing list, so patches
don't get interspersed with other development subjects?

On Sat, 2009-05-02 at 23:19 +0200, Nikolai Prokoschenko wrote:

> Oliver Charles <[hidden email]> writes:
>
> > Seriously, I come back to my inbox after 2 hours and find it bursting
> > with 60 patches. That's not going to help anyone and is just going to
> > lead to bad reviews. Give us a few patches at a time and we can
> > systematically work through them. This is better than a monolithic
> > patch, but this is still pretty crazy.
>
> I have to say I understand your anger, but I personally am perfectly
> fine with that. I prefer that to a lot of mails in the mailing list.
>
> We now have a lot of patches in the queue which can be
> worked on piece by piece -- neither should you review all that stuff at
> once nor should you review that alone. Many patches at once are only
> problematic for the submitter, since he's the one responsible for the
> patch to apply cleanly (something RB checks rudimentally). It's also his
> problem if some of his later patches require earlier patches to get
> submitted. And I also prefer having too many patches to review than too
> few, since that actually means we *have* so many patches at all. None of
> those get lost, as opposed to patches in the mailing list.
>
> As for the second problem, mail filtering, I do understand the problem
> with e-mail address forging, but it helps to follow the discussion
> cleanly. I however don't understand the problem with too many mails:
> it's not difficult at all to sort those mails out, for example by
> setting your e-mail address to [hidden email]. If you don't
> like them, remove you address at all. It also helps not having all users
> in the default reviewer group but rather separating them into topic
> groups, e.g. NGS, JS, Templates.
>
> But maybe that's just me -- I prefer having too much information to too
> little. In any case we shouldn't be encouraging developers to submit
> less patches just because our infrastructure can't handle that yet.
>
> Nikolai.
>
>
> _______________________________________________
> MusicBrainz-devel mailing list
> [hidden email]
> http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Nikolai Prokoschenko
Administrator
"Paul C. Bryan" <[hidden email]> writes:

> Is it worth spinning off patches to a different mailing list, so patches
> don't get interspersed with other development subjects?

Could be, and this ML could be then included in the default reviewers
list. However, if someone really wants to do reviews they should sign up
anyway and then they'll get all mails from Review board. No need for an
additional ML.

Nikolai.


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Can we chill out on the patches?

Pavan Chander

RB currently sends out emails with the recipients in the To: field and while this is probably not an issue for anyone who is currently signed up to the list, I don't think that's the "done" thing to do.

As you said, anyone who wants to do reviews can sign up, but what if someone just wants to keep tabs on progress, and not actively participate in the actual reviewing? They would end up having their name and email address addressed on each email, no matter the level of participation, and that may not be what they expect when they sign up. I certainly didn't expect to see my name/email on each email that RB sent out, and I'm sure a lot of others didn't expect that either.

Having a ML that everyone could subscribe to would solve this "problem".

Another reason, and advantage actually, of setting up a ML for RB is that the comments/discussions would be stored online in an archive for easier browsing and, using Google, they would be easier to search through at a later date if the need arose.


Pavan Chander // navap


On Sat, May 2, 2009 at 6:43 PM, Nikolai Prokoschenko <[hidden email]> wrote:
"Paul C. Bryan" <[hidden email]> writes:

> Is it worth spinning off patches to a different mailing list, so patches
> don't get interspersed with other development subjects?

Could be, and this ML could be then included in the default reviewers
list. However, if someone really wants to do reviews they should sign up
anyway and then they'll get all mails from Review board. No need for an
additional ML.

Nikolai.


_______________________________________________
MusicBrainz-devel mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-devel
Loading...