Created: (LB-21) Improve robustness of last.fm importer

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (LB-21) Improve robustness of last.fm importer

JIRA jira-admin@musicbrainz.org
Improve robustness of last.fm importer
--------------------------------------

                 Key: LB-21
                 URL: http://tickets.musicbrainz.org/browse/LB-21
             Project: ListenBrainz
          Issue Type: Improvement
          Components: last.fm importer
            Reporter: Robert Kaye


As per our twitter discussion:

> Next question: If the scraper receives an error while loading a last.fm page, does it retry?

> it has some retry but not lots of retry and it could be better

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Commented: (LB-21) Improve robustness of last.fm importer

JIRA jira-admin@musicbrainz.org

    [ http://tickets.musicbrainz.org/browse/LB-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37173#action_37173 ]

Alastair Porter commented on LB-21:
-----------------------------------

Retry should treat toReport as a stack and not loop through it in multiple callbacks
https://github.com/metabrainz/listenbrainz-server/blame/master/webserver/templates/user/scraper.js#L130-L134

Retry should not retry on http400

> Improve robustness of last.fm importer
> --------------------------------------
>
>                 Key: LB-21
>                 URL: http://tickets.musicbrainz.org/browse/LB-21
>             Project: ListenBrainz
>          Issue Type: Improvement
>          Components: last.fm importer
>            Reporter: Robert Kaye
>
> As per our twitter discussion:
> > Next question: If the scraper receives an error while loading a last.fm page, does it retry?
> > it has some retry but not lots of retry and it could be better

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Closed: (LB-21) Improve robustness of last.fm importer

JIRA jira-admin@musicbrainz.org
In reply to this post by JIRA jira-admin@musicbrainz.org

     [ http://tickets.musicbrainz.org/browse/LB-21?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Porter closed LB-21.
-----------------------------

    Resolution: Fixed

These changes have been done

> Improve robustness of last.fm importer
> --------------------------------------
>
>                 Key: LB-21
>                 URL: http://tickets.musicbrainz.org/browse/LB-21
>             Project: ListenBrainz
>          Issue Type: Improvement
>          Components: last.fm importer
>            Reporter: Robert Kaye
>
> As per our twitter discussion:
> > Next question: If the scraper receives an error while loading a last.fm page, does it retry?
> > it has some retry but not lots of retry and it could be better

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs