Created: (LB-43) Add messybrainz bulk submission endpoint

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (LB-43) Add messybrainz bulk submission endpoint

JIRA jira-admin@musicbrainz.org
Add messybrainz bulk submission endpoint
----------------------------------------

                 Key: LB-43
                 URL: http://tickets.musicbrainz.org/browse/LB-43
             Project: ListenBrainz
          Issue Type: Bug
          Components: MessyBrainz
            Reporter: Alastair Porter


We currently need to send one request from listenbrainz to messybrainz for every song in a bulk submit request. This means we make 50 http requests for every submission. We should instead implement a bulk messybrainz endpoint that takes a list of items and returns a list of msids.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Commented: (LB-43) Add messybrainz bulk submission endpoint

JIRA jira-admin@musicbrainz.org

    [ http://tickets.musicbrainz.org/browse/LB-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37191#action_37191 ]

Alastair Porter commented on LB-43:
-----------------------------------

just adding this for future notes: http://flask.pocoo.org/docs/0.10/security/#json-security
We can't return a list from jsonify, perhaps it's reasonable to return an object with status/items. I don't think this attack vector will affect us in messybrainz, but perhaps its still best practice

> Add messybrainz bulk submission endpoint
> ----------------------------------------
>
>                 Key: LB-43
>                 URL: http://tickets.musicbrainz.org/browse/LB-43
>             Project: ListenBrainz
>          Issue Type: Bug
>          Components: MessyBrainz
>            Reporter: Alastair Porter
>
> We currently need to send one request from listenbrainz to messybrainz for every song in a bulk submit request. This means we make 50 http requests for every submission. We should instead implement a bulk messybrainz endpoint that takes a list of items and returns a list of msids.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Closed: (LB-43) Add messybrainz bulk submission endpoint

JIRA jira-admin@musicbrainz.org
In reply to this post by JIRA jira-admin@musicbrainz.org

     [ http://tickets.musicbrainz.org/browse/LB-43?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alastair Porter closed LB-43.
-----------------------------

    Resolution: Fixed

Done, both the web service and module support a list of items

> Add messybrainz bulk submission endpoint
> ----------------------------------------
>
>                 Key: LB-43
>                 URL: http://tickets.musicbrainz.org/browse/LB-43
>             Project: ListenBrainz
>          Issue Type: Bug
>          Components: MessyBrainz
>            Reporter: Alastair Porter
>
> We currently need to send one request from listenbrainz to messybrainz for every song in a bulk submit request. This means we make 50 http requests for every submission. We should instead implement a bulk messybrainz endpoint that takes a list of items and returns a list of msids.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs