Created: (LB-44) Move submission validation to messybrainz

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (LB-44) Move submission validation to messybrainz

JIRA jira-admin@musicbrainz.org
Move submission validation to messybrainz
-----------------------------------------

                 Key: LB-44
                 URL: http://tickets.musicbrainz.org/browse/LB-44
             Project: ListenBrainz
          Issue Type: Improvement
          Components: API
            Reporter: Alastair Porter


Currently we read a submission, parse the json, validate it, serialise back to a string, send the data to messybrainz, which parses, processes, and sends a result back, then listenbrainz parses the msb response, alters it, serialises it, and sends to kafka.

If we move validation to a special endpoint in messybrainz then we can remove an entire deserialise/serialise cycle which should use less cpu.

If messybrainz decides that the data is invalid it should raise http400, which listenbrainz can catch and resend back to the client.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Closed: (LB-44) Move submission validation to messybrainz

JIRA jira-admin@musicbrainz.org

     [ http://tickets.musicbrainz.org/browse/LB-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Kaye closed LB-44.
-------------------------

    Resolution: Won't Fix

We agreed to build a messybrainz library and keep validation in ListenBrainz.

> Move submission validation to messybrainz
> -----------------------------------------
>
>                 Key: LB-44
>                 URL: http://tickets.musicbrainz.org/browse/LB-44
>             Project: ListenBrainz
>          Issue Type: Improvement
>          Components: API
>            Reporter: Alastair Porter
>
> Currently we read a submission, parse the json, validate it, serialise back to a string, send the data to messybrainz, which parses, processes, and sends a result back, then listenbrainz parses the msb response, alters it, serialises it, and sends to kafka.
> If we move validation to a special endpoint in messybrainz then we can remove an entire deserialise/serialise cycle which should use less cpu.
> If messybrainz decides that the data is invalid it should raise http400, which listenbrainz can catch and resend back to the client.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs