Created: (LB-72) Undefined variable artist_mbid

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Created: (LB-72) Undefined variable artist_mbid

JIRA jira-admin@musicbrainz.org
Undefined variable artist_mbid
------------------------------

                 Key: LB-72
                 URL: http://tickets.musicbrainz.org/browse/LB-72
             Project: ListenBrainz
          Issue Type: Bug
          Components: API
            Reporter: Wieland Hoffmann


artist_mbid in https://github.com/metabrainz/listenbrainz-server/blob/e575335f90fa8dd39aac00058d3673cbaf945b0d/webserver/views/api.py#L205 doesn't exist.

The last key ('artist_id') also looks wrong, everything else uses artist_mbids, but maybe it should contain the first artist mbid or something.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs
Reply | Threaded
Open this post in threaded view
|

Commented: (LB-72) Undefined variable artist_mbid

JIRA jira-admin@musicbrainz.org

    [ http://tickets.musicbrainz.org/browse/LB-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=37266#action_37266 ]

Alastair Porter commented on LB-72:
-----------------------------------

This code won't trigger yet, because we don't return mbids from messybrainz yet. That will be why we haven't caught it yet.

It does look like the keys and variables should all be changed to artist_mbids

> Undefined variable artist_mbid
> ------------------------------
>
>                 Key: LB-72
>                 URL: http://tickets.musicbrainz.org/browse/LB-72
>             Project: ListenBrainz
>          Issue Type: Bug
>          Components: API
>            Reporter: Wieland Hoffmann
>
> artist_mbid in https://github.com/metabrainz/listenbrainz-server/blob/e575335f90fa8dd39aac00058d3673cbaf945b0d/webserver/views/api.py#L205 doesn't exist.
> The last key ('artist_id') also looks wrong, everything else uses artist_mbids, but maybe it should contain the first artist mbid or something.

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs