Created: (LB-73) return meaningful errors with bad requests.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Created: (LB-73) return meaningful errors with bad requests.

JIRA jira-admin@musicbrainz.org
return meaningful errors with bad requests.
-------------------------------------------

                 Key: LB-73
                 URL: http://tickets.musicbrainz.org/browse/LB-73
             Project: ListenBrainz
          Issue Type: Improvement
          Components: API
            Reporter: marc


currently, i don't think the "_validate_auth_header()" function is working as expected...

https://github.com/metabrainz/listenbrainz-server/blob/master/webserver/views/api.py#L108

if you omit the "Authorization" header completely, it returns HTTP status 0 with no response text.
if you include the "Authorization" header but with no token, it also returns HTTP status 0 with no response text.

and if you omit the "artist_name" or "track_name" parameters, you do get a meaningful error.. but it's returned as HTML. it should be JSON.




--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://tickets.musicbrainz.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

_______________________________________________
MusicBrainz-bugs mailing list
[hidden email]
http://lists.musicbrainz.org/mailman/listinfo/musicbrainz-bugs